Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven module build breaks #329

Open
KyRobbins opened this issue Jul 8, 2024 · 1 comment
Open

Maven module build breaks #329

KyRobbins opened this issue Jul 8, 2024 · 1 comment

Comments

@KyRobbins
Copy link

Using jaxb2-maven-plugin:2.5.0, When doing a maven build using the following module structure

root_dir/
├─ parent/
│  ├─ pom.xml
├─ sub-module/
│  ├─ src/
│  │  ├─ main/
│  │  │  ├─ java/
│  │  │  ├─ resources/
│  │  │  ├─ xsd/
│  │  ├─ test/
│  ├─ pom.xml
├─ .gitignore

Building using the parent results in a failure due to the fact that the base directory for the execution is */root_dir/parent, which means the check on

if (path.toLowerCase().startsWith(basedirPath.toLowerCase())) {
fails, since the actual xsd source is in */root_dir/sub-module/src/main/xsd, and you end up with a concatenated path of */root_dir/parent/*/root_dir/sub-module/.

This appears to be a bug, and is only an issue in this particular module project structure where the parent and sub-module are sibling directories, and this structure won't change for my current project. I also do not have the ability to downgrade to 2.3.1 (which does not contain this bug) because I'm building with JDK17, which is missing some required classes, but at the same time, I can't jump to 3.x of the plugin because javax is still being used prolifically through the code base and it's not an option to change that at this time.

@KyRobbins
Copy link
Author

KyRobbins commented Jul 8, 2024

Adding to this, there is a separate bug in the same FileSystemUtilities#relativize(String, File, boolean) method of 2.5.0 for windows systems. The value returned by URL#getPath() returns a / delimited path String (with a / prefix), which is used to feed this method. The baseDirPath is derived using File#getPath() on parentDir, which results in a \ delimited path String.

This will result in

if (path.toLowerCase().startsWith(basedirPath.toLowerCase())) {
never resolving to true in any situation (and the case-insensitivity can lead to issues on Windows I would assume). The final check for toReturn.startsWith(File.separator) will also fail, as the URL#getPath() prefixed with a /, not the windows native \, meaning the return statement will return an absolute path.

This is a jumble of different bugs that cancel each other out on Windows, but not on a Unix system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant