Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test chart data #2311

Open
ADBond opened this issue Aug 7, 2024 · 0 comments
Open

Test chart data #2311

ADBond opened this issue Aug 7, 2024 · 0 comments

Comments

@ADBond
Copy link
Contributor

ADBond commented Aug 7, 2024

We don't have many, if any, tests of the actual contents of charts - mostly just that the code runs. It would probably be useful to add some tests to assert that the charts output (at least data-wise) what they should.

For example, before #2309, the completeness chart in Spark scored everything as 100% regardless of column contents, as instead of the actual column name in the SQL, due to a quoting error, it was mistakenly given a string literal (which is always there - it is a literal!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant