-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content UI Does Not Follow Symbolic Links (yet launcher does) #1236
Labels
bug
Something isn't working
Comments
Geometrically
added a commit
that referenced
this issue
Jul 4, 2024
* Begin UI for threads and moderation overhaul * Hide close button on non-report threads * Fix review age coloring * Add project count * Remove action buttons from queue page and add queued date to project page * Hook up to actual data * Remove unused icon * Get up to 1000 projects in queue * prettier * more prettier * Changed all the things * lint * rebuild * Add omorphia * Workaround formatjs bug in ThreadSummary.vue * Fix notifications page on prod * Fix a few notifications and threads bugs * lockfile * Fix duplicate button styles * more fixes and polishing * More fixes * Remove legacy pages * More bugfixes * Add some error catching for reports and notifications * More error handling * fix lint * Add inbox links * Remove loading component and rename member header * Rely on threads always existing * Handle if project update notifs are not grouped * oops * Fix chips on notifications page * Import ModalModeration * finish threads * New authentication (#1234) * Initial new auth work * more auth pages * Finish most * more * fix on landing page * Finish everything but PATs + Sessions * fix threads merge bugs * fix cf pages ssr * fix most issues * Finish authentication * Fix merge --------- Co-authored-by: triphora <[email protected]> Co-authored-by: Jai A <[email protected]> Co-authored-by: Geometrically <[email protected]>
Norbiros
added a commit
to Norbiros/code
that referenced
this issue
Jul 4, 2024
Norbiros
added a commit
to Norbiros/code
that referenced
this issue
Jul 18, 2024
Ensures correct symlink resolution for specific mods, the mods directory, and the entire profile directory.
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 20, 2024
* fix(theseus): Resolve log tab freezing entire app (#1127, #1237) Switched to `vue-typed-virtual-list` due to freezing issues in WebKit caused by `vue-virtual-scroller`, which were difficult to resolve with the previous library. * fix(theseus): Double opening of Socials Share link (#1136, #1074) * fix(theseus): Proper symlinks resolution (#1236) Ensures correct symlink resolution for specific mods, the mods directory, and the entire profile directory. * fix(theseus): Correctly recognize NeoForge mods (#1215) * fix(theseus): Corrected `Environments` and `Loaders` filters (#899) * fix(theseus): Remove `_JAVA_OPTIONS` when testing JRE (#1171) * fix(theseus): Fixed opening files using `show_in_folder` Previously, opening a mod would display the contents of the JAR file instead of its location. * fix(theseus): Hide `.DS_Store` files (#1274, #1002, #1174) * fix(theseus): Corrected tooltip color * fix(theseus): Fixed white mode issues (#1144, #1010) * fix: Corrected `Slider` min and max value handling (#1008) * fix: Fixed rebase problems * fix: Fixed `:deep` usage warning * chore: Updated eslint plugins to fix conflicts with Prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On macOS ARM the UI does not correctly follow symbolic links; however, when launching the game the mods are loaded as expected. This issue may be related to #1032, and I believe full support of symbolic links (with documentation) may partially address #992, #949 and #813 (i.e. synced state between devices) - see below for a further discussion on this.
Steps to reproduce
The below was tried with a fresh install and just fabric-api, but the behaviour is observed with many mods too.
ln -s /source/path/mods ~/Library/Application\ Support/com.modrinth.theseus/profiles/ModrinthProfile
Expected behavior
The launcher and UI should have consistent behaviour - ideally both supporting symbolic linking of the mods folder.
System information
Apple M2 Pro, Theseus v0.7.1
Additional context
Great job on a fantastic launcher! One of the key missing features however, is better support for those of us that switch between multiple devices. There are several open issues regarding this:
Note that the third issue is very similar to this issue, yet for this issue I would consider it closed if just having a symbolic link of the mods folder is supported, whereas #992 is regarding symlinking further folders and handling profile.json conflicts.
Roll Your Own Cloud Sync
For those that aren't aware of how to roll their own sync, I follow the rough steps below:
ln -s $wherever_you_put/mods $wherever_modinth_folder_is/com.modrinth.theseus/profiles/$the_profile_you_want_to_sync/
The text was updated successfully, but these errors were encountered: