Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the mod is owned by an organization, the owner is not visible #1229

Open
Shihyeon opened this issue Jun 16, 2024 · 0 comments
Open

If the mod is owned by an organization, the owner is not visible #1229

Shihyeon opened this issue Jun 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Shihyeon
Copy link

Shihyeon commented Jun 16, 2024

Describe the bug

If the owner of the project is an organization rather than a user, the owner will not be visible in the modrinth-theseus launcher instance.

Steps to reproduce

  1. Install a mod (e.g. Mod Menu mod) owned by organization on the instance.
  2. Check the owner of the mod within the instance in the library

Expected behavior

If the owner is a user, the user name is displayed;
if the owner is an organization, nothing is displayed.

System information

Windows 11 Home 23H2
Theseus v0.7.1

Additional context

modmenu and worldedit are owned by organizations.

image

I think,
/theseus_gui/src/pages/instance/Mods.vue#L225
/theseus_gui/src/pages/instance/Mods.vue#L454

            <Avatar :src="mod.icon" />
            <div v-tooltip="`${mod.name} by ${mod.author}`" class="mod-text">
              <div class="title">{{ mod.name }}</div>
              <span class="no-wrap">by {{ mod.author }}</span>
            </div>

When loading {{ mod.author }}, there is no logic to load the organization.

@Shihyeon Shihyeon added the bug Something isn't working label Jun 16, 2024
Geometrically added a commit that referenced this issue Jul 4, 2024
* move to cloudflare workers

* remove junk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant