Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Acquisitions duplicates rows when refreshCharts() is called after initial load #41

Open
Mark-H opened this issue May 28, 2021 · 3 comments

Comments

@Mark-H
Copy link
Member

Mark-H commented May 28, 2021

Need to better parse the data from the report to make sure it can be rendered properly. Right now it's either showing incorrect values or it looks different with each request.

Schermafbeelding 2021-05-28 om 22 18 12

@Mark-H Mark-H added this to the Big Brother 2 feature complete milestone May 28, 2021
@muzzwood
Copy link

muzzwood commented Jun 1, 2021

Perhaps it's me having a different dataset, but I don't seem to be able to replicate this one at the moment.

@Mark-H
Copy link
Member Author

Mark-H commented Jun 5, 2021

Must've been some messed up cache, seems to be working fine now 🤷

@Mark-H Mark-H closed this as completed Jun 5, 2021
@Mark-H Mark-H reopened this Jun 5, 2021
@Mark-H
Copy link
Member Author

Mark-H commented Jun 5, 2021

This happens when the info is refreshed with BigBrother.refreshCharts() after the chart was already rendered with data. That's a bit of an edge case and not something we're (currently) doing anywhere but in init which was fixed with introducing the debounce, but keeping this open in case we add some refreshing magic to it.

@Mark-H Mark-H changed the title [BB2] Acquisitions doesn't work properly [2.x] Acquisitions doesn't work properly Aug 2, 2021
@Mark-H Mark-H changed the title [2.x] Acquisitions doesn't work properly [2.x] Acquisitions duplicates rows when refreshCharts() is called after initial load Aug 2, 2021
@Mark-H Mark-H removed this from the Big Brother 2 feature complete milestone Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants