Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken dependency on Moment #32

Closed
csvan opened this issue Jun 6, 2015 · 2 comments
Closed

Broken dependency on Moment #32

csvan opened this issue Jun 6, 2015 · 2 comments

Comments

@csvan
Copy link

csvan commented Jun 6, 2015

Currently, installing via npm and trying to use the module yields:

ReferenceError: moment is not defined
    at link (http://localhost:3001/node_modules/material-date-picker/build/mbdatepicker.js:54:19)
    at http://localhost:3001/node_modules/angular/angular.js:8598:44
    at invokeLinkFn (http://localhost:3001/node_modules/angular/angular.js:8604:9)
    at nodeLinkFn (http://localhost:3001/node_modules/angular/angular.js:8113:11)
    at compositeLinkFn (http://localhost:3001/node_modules/angular/angular.js:7514:13)
    at compositeLinkFn (http://localhost:3001/node_modules/angular/angular.js:7518:13)
    at compositeLinkFn (http://localhost:3001/node_modules/angular/angular.js:7518:13)
    at publicLinkFn (http://localhost:3001/node_modules/angular/angular.js:7388:30)
    at compile (http://localhost:3001/node_modules/angular-ui-router/release/angular-ui-router.js:4026:9)
    at invokeLinkFn (http://localhost:3001/node_modules/angular/angular.js:8604:9) <mb-datepicker element-id="date1" input-class="testClass" input-name="testName" arrows="arrows" calendar-header="header" date="date" date-format="YYYY-MM-DD" class="ng-isolate-scope">

Installing and including Moment manually resolves the issue.

@mobinni
Copy link
Owner

mobinni commented Jun 6, 2015

bower install moment
also it should automatically install moment as a dependency and add it

@mobinni mobinni closed this as completed Jun 6, 2015
@csvan
Copy link
Author

csvan commented Jun 12, 2015

This does not happen when installing via NPM (your package.json does not list Moment as a dep).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants