Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only datamessages should be passed to auxincli output queue in core.py #30

Open
iamalwaysuncomfortable opened this issue Nov 17, 2021 · 1 comment

Comments

@iamalwaysuncomfortable
Copy link
Contributor

iamalwaysuncomfortable commented Nov 17, 2021

Auxin CLI no longer ouputs lists under params. Core.py logic should maybe filter for only datamessages?

Lines between
https://github.com/forestcontact/forest-draft/blob/78f2ddff11998741ec7d96d0039f98bd51c5f56e/forest/core.py#L190
and
https://github.com/forestcontact/forest-draft/blob/metrics/forest/core.py#L205

could be refactored to: https://gist.github.com/iamalwaysuncomfortable/42c5aeb57fa365be0018ecd7b7f6b2ad

If it's desired to only have datamessages enter the message output queue.

┆Issue is synchronized with this Asana task by Unito

@technillogue
Copy link
Contributor

technillogue commented Jan 3, 2022

is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants