Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to select dates in range format #32

Open
stshelton opened this issue Mar 1, 2018 · 13 comments · May be fixed by #125
Open

Ability to select dates in range format #32

stshelton opened this issue Mar 1, 2018 · 13 comments · May be fixed by #125

Comments

@stshelton
Copy link

Is there a way to select dates by range instead of either daily or multiple days? So if a user selected Monday to Friday all days in between would be selected too.

@mmick66
Copy link
Owner

mmick66 commented Mar 8, 2018

There is not provision for that currently. I was thinking about it though, so might do some work to add this.

@haroldogtf
Copy link

The ability to select dates in range will be awesome!

@haroldogtf
Copy link

@mmick66 Will this be included in the project? Do you have any deadlines?

@mmick66
Copy link
Owner

mmick66 commented May 23, 2018

I'll see if I can work on it today.

@haroldogtf
Copy link

@mmick66 Thanks a lot!

@Omar-Kay
Copy link

Omar-Kay commented Jul 7, 2018

I'd like to work on it.

@mmick66
Copy link
Owner

mmick66 commented Jul 7, 2018

Great! @Omar-Kay. I recently implemented the ability to add new events. The trigger I selected is a long press, so I don't know how the user will be able to select ranges. Worst case we can find another way to add events.

Go ahead and I will check your pull requests. Thanks!

@Omar-Kay
Copy link

Omar-Kay commented Jul 8, 2018

So I implemented on the cocoapods version a successful implementation of this feature, controlled by new a public bool rangeSelectionEnable, but I was stuck when trying to merge those changes with the latest changes on git. I've thusly shared with you the changed files, and you can try it out on the older version (latest version on cocoapods) until I figure out how to make it work on the git version, unless you have another suggestion.

Also, left a video of showing the pod modified version ;). I didn't want to attach too much, but I've tested that when the flag is disabled, it works like before.

Calendar view range selectable video.zip
Changed calendar view files (from pod version).zip

@Omar-Kay
Copy link

Omar-Kay commented Jul 8, 2018

Nevermind! Got it to work on the main branch as well now! How do I initiate a merge request?

@Omar-Kay
Copy link

Omar-Kay commented Jul 8, 2018

image

Ran into this issue while trying to push. Any suggestions @mmick66 ?

@mmick66
Copy link
Owner

mmick66 commented Jul 9, 2018

Great. This is probably because you are trying to merge to the main branch directly. I suspect that you just cloned the project and worked from there. What you should do rather is a pull request. The way it's done is that you need to create a pull request.

To do that, fork the project (if you haven't already), include the changes in the forked repo, push them (it will be your repo so you should have all the privileges), and then go to the pull request tab and create a new pull request. Remember, a pull request is only created between forks.

Good luck, and thank you for your work.

@Omar-Kay
Copy link

Omar-Kay commented Jul 9, 2018

Great, thanks for that! I've added a pull request

@mmick66
Copy link
Owner

mmick66 commented Jul 9, 2018

@Omar-Kay: There are issues with your changes and I had to revert. Please check what happens when you select a range across months. Start from one month and finish in the next one for example. There is something wrong there. Also, another problem is when you select a range, deselect, and then try to select starting from the same date. In this case it does not select it.

@levous levous linked a pull request May 13, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants