Unknown recipients are not logged #232
Comments
mjl-
added a commit
that referenced
this issue
Nov 1, 2024
…e recipient before this change, we were logging an empty string, which turned into "[]", looking like an empty array. misleading and unhelpful. this is fixed by making struct fields on type recipient "exported" so they can get logged, and by changing the logging code to log nested struct/pointer/interface fields if we would otherwise wouldn't log anything (when only logging more basic data types). we'll now get log lines like: l=info m="deliver attempt to unknown user(s)" pkg=smtpserver recipients="[[email protected]]" for issue #232 by snabb, thanks for reporting!
|
@snabb Thanks for reporting. I thing the commit above fixes the issue. The commit message has more details. See https://www.xmox.nl/b/#598c5ea6ac9f4a5ac0b6404102b776818f11b6d4 for a binary with this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After migrating some domains over to mox, I woud like to monitor the logs for attempts to send e-mail to non-existing addresses. It could be an indication that I have failed to migrate some addresses. It would be also useful to see if anyone is trying to enumerate possible addresses.
Unfortunately I found that when external delivery attempt to unknown recipients is logged, the recipients entry is always empty. I was not able to find any log entry containing the recipient address even though I have debug level logging enabled.
See example below:
I looked at the code where this is logged, but it wasn't immediately obvious to me why
recipientswould end up being empty.This is with mox-v0.0.12-go1.23.2.
The text was updated successfully, but these errors were encountered: