Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(backend): replace punyHost with new URL().host #15164

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

refactor(backend): replace punyHost with new URL().host #15164

wants to merge 2 commits into from
+14 −23

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Dec 21, 2024 •
edited
Loading

What

タイトル通り

Closes #15163

Why

コード量を減らすため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2024 •
edited
Loading

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 39.94%. Comparing base (f123be3) to head (da3fd90).

Files with missing lines Patch % Lines
...end/src/core/activitypub/models/ApPersonService.ts 60.00% 4 Missing ⚠️
...s/backend/src/core/activitypub/ApRequestService.ts 0.00% 1 Missing ⚠️
.../backend/src/core/activitypub/ApResolverService.ts 0.00% 1 Missing ⚠️
...ckend/src/core/activitypub/models/ApNoteService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #15164      +/-   ##
===========================================
- Coverage    39.95%   39.94%   -0.01%     
===========================================
  Files         1563     1563              
  Lines       197878   197869       -9     
  Branches      3635     3631       -4     
===========================================
- Hits         79059    79047      -12     
- Misses      118215   118217       +2     
- Partials       604      605       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

別に用意されていたということはなにか事情があった可能性があるので、URL.hostと完全に等価なものかどうかを確認する必要がありそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR
Projects
[実験中] 管理用
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace UtilityService.punyHost(url) with new URL(url).host
2 participants
@saschanaz @kakkokari-gtyih