Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MkInstanceTickerの情報がリアクティブでない問題を修正 #15123

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 13, 2024

What

プラグインでinstance情報周りを書き換えても、その書換がMkInstanceTickerまで伝播していなかったのを修正

Why

Fix #15122

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.32%. Comparing base (0804092) to head (3034547).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15123       +/-   ##
============================================
- Coverage    39.95%   19.32%   -20.64%     
============================================
  Files         1563      728      -835     
  Lines       197780   103834    -93946     
  Branches      3633      991     -2642     
============================================
- Hits         79029    20064    -58965     
+ Misses      118178    83216    -34962     
+ Partials       573      554       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

Can't change note.user.instance.name with register_note_view_interruptor
1 participant