Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check length of symmetric key in JsonWebKeyType::compatible_with #29

Closed
Stupremee opened this issue Jul 30, 2022 · 0 comments · Fixed by #89
Closed

Check length of symmetric key in JsonWebKeyType::compatible_with #29

Stupremee opened this issue Jul 30, 2022 · 0 comments · Fixed by #89
Labels
release:0.1 Issues which must be solved for the 0.1 release

Comments

@Stupremee
Copy link
Contributor

Currently, any symmetric algorithm is accepted for any symmetric key. However, depending on the algorithm, there should be additional checks regarding the key length to check if a key is compatible with an algorithm.

Example

Hmac::Hs256 should not be compatible with an OctetSequence key that is only 16 bytes long.
@Stupremee Stupremee changed the title Check length of symmetric key in JsonWebType::compatible_with Check length of symmetric key in JsonWebKeyType::compatible_with Jul 30, 2022
@Erik1000 Erik1000 added the release:0.1 Issues which must be solved for the 0.1 release label Aug 5, 2022
@Stupremee Stupremee linked a pull request Nov 4, 2023 that will close this issue
fix: verify key length in compatible_with method #89
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release:0.1 Issues which must be solved for the 0.1 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: verify key length in compatible_with method minkan-chat/jose
2 participants
@Stupremee @Erik1000