Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheusOperator: true add, then delete scrape config continously #2218

Open
pasztorl opened this issue Jul 16, 2024 · 12 comments
Open

prometheusOperator: true add, then delete scrape config continously #2218

pasztorl opened this issue Jul 16, 2024 · 12 comments

Comments

@pasztorl
Copy link

I've added prometheusOperator: true to a tenant config then i just see this in the logs:

I0716 15:03:49.705015       1 prometheus.go:178] Deleting MinIO tenant Prometheus scrape config
I0716 15:03:52.595321       1 prometheus.go:120] Adding MinIO tenant Prometheus scrape config
I0716 15:03:54.742093       1 prometheus.go:178] Deleting MinIO tenant Prometheus scrape config
I0716 15:03:57.604896       1 prometheus.go:120] Adding MinIO tenant Prometheus scrape config
I0716 15:03:59.761052       1 prometheus.go:178] Deleting MinIO tenant Prometheus scrape config
I0716 15:04:02.631716       1 prometheus.go:120] Adding MinIO tenant Prometheus scrape config
I0716 15:04:04.771914       1 prometheus.go:178] Deleting MinIO tenant Prometheus scrape config

How can I debug the problem?

@cesnietor
Copy link
Contributor

@pasztorl could you please add your prometheus configuration yaml and crd. Thanks.

@cesnietor cesnietor changed the title [5.0.15] prometheusOperator: true add, then delete scrape config continously prometheusOperator: true add, then delete scrape config continously Jul 22, 2024
@pasztorl
Copy link
Author

Hi,

I set two things related to this:

Operator chart:

operator:
  env:
    - name: PROMETHEUS_NAMESPACE
      value: "monitoring"
    - name: PROMETHEUS_NAME
      value: "prometheus-prometheus"

The operator can find prometheus, because when it was not set properly I got different error messages.

On tenant:

spec:
  prometheusOperator: true

Prometheus installed with kube-prometheus-stack chart.

@pasztorl
Copy link
Author

pasztorl commented Jul 22, 2024

Now I do a retry, now I got this message from the operator:

E0722 17:17:24.054527 1 main-controller.go:749] error syncing 'devel/minio': prometheus-prometheus-scrape-confg is alreay set as additional scrape config in prometheus

Which is true, because I use additional scrape config so the prometheus-prometheus-scrape-confg secret exists in the monitoring ns.

My scape config looks like this:

- job_name: node-exporter-jump
  static_configs:
  - targets:
    - jump1.int.hu1.example.com:9100

@cesnietor
Copy link
Contributor

could you please check if the secret is being created? minio-prom-additional-scrape-config can you also check if the contents of it are the same as your scrape config?

@pasztorl
Copy link
Author

I've deleted my own scrape config secret then I restarted the minio operator.
Interesting, that I got the same error message while the secret not created by the minio operator.
How the operator checks that is scrape config exists?

I've not found minio-prom-additional-scrape-config secret on any ns.

@cesnietor
Copy link
Contributor

cesnietor commented Jul 22, 2024

please share your full tenant yaml as well as your operator .

@cesnietor
Copy link
Contributor

also please share the full operator logs after restart

@pasztorl
Copy link
Author

I've attached the tenant and the operator deployment
operator-deployment.txt
tenant.txt

@pasztorl
Copy link
Author

I've set the prometheusOperator: false. Restarted the operator, then after the restart I switched back to true. Here is the log.
operatorlog.txt

@cesnietor
Copy link
Contributor

cesnietor commented Jul 22, 2024

you need to remove the prometheus-prometheus-scrape-confg from the prometheus AdditionalScrapeConfigs field. we error out when something other than minio-prom-additional-scrape-config is set.

@pasztorl
Copy link
Author

pasztorl commented Jul 22, 2024

Actually I using this AdditionalScrapeConfigs to monitor nodes that have node-exporter but not a node within the k8s cluster, so this is why I need the AdditionalScrapeConfigs.
Maybe I can use the "Scrape Config" crd, also what do you think, minio operatod should use also the Scrape Config crd, not the secret?
So the prometheus deployment is not dedicated to minio, I would like to use the cluster-wide deployment for it if possible.

@cesnietor
Copy link
Contributor

cesnietor commented Jul 22, 2024

Right now it can only point to one secret, and minio needs that one I mentioned to work. and the key also has to be the same. To fix your case, rename your secret with your custom config to the one I mentioned. MinIO operator will be happy seeing that the name is the one it looks for and it will append the minio scrape config it needs.
Let me know if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants