Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed presign url signing #1158

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vugarli
Copy link

@vugarli vugarli commented Aug 17, 2024

Fixes #1150

  • Now headers gets included in the signature appropriately
  • Did some cleanup

@ebozduman
Copy link
Collaborator

ebozduman commented Aug 21, 2024

@vugarli
Please look into your build failure (1st build test failure) and format-check test (2nd build failure).
For format check, you basically run dotnet regitlint in your branch and push the suggested format changes in.

@vugarli
Copy link
Author

vugarli commented Aug 24, 2024

@vugarli Please look into your build failure (1st build test failure) and format-check test (2nd build failure). For format check, you basically run dotnet regitlint in your branch and push the suggested format changes in.

Done. Will look into functional test failing, play.min.io seems to be down for now

@ebozduman
Copy link
Collaborator

ebozduman commented Aug 26, 2024

@vugarli

Yes, play.min.io was down. The issue is resolved now and it is up and running.

The failure is about your changes: System.InvalidOperationException: Unable to download via presigned URL Content

@vugarli
Copy link
Author

vugarli commented Aug 30, 2024

@ebozduman
I have changed the test to reflect the new behavior of signing. Old one used to include headers as query parameters, which was the reason test was passing before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Type header value is wrong in the presigned put url
2 participants