Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slashes are appended to routes that have query params #156

Open
ergo opened this issue Dec 13, 2016 · 1 comment · May be fixed by #157
Open

Trailing slashes are appended to routes that have query params #156

ergo opened this issue Dec 13, 2016 · 1 comment · May be fixed by #157

Comments

@ergo
Copy link

ergo commented Dec 13, 2016

Route in form of:

/{foo}{?query}
/{foo}:?query:

Would end up being interpolated as /foo/?params which is unexpected to happen because trailing slash carries meaning for REST servers.
@ergo ergo linked a pull request Dec 13, 2016 that will close this issue
Open
@zhang356
Copy link

Hi, is this merged in? I installed the latest crossroads.js using NPM, it doesn't seem to have this change in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #156 - do not append unexpected trailing slashes to routes with…
2 participants
@ergo @zhang356