Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable interleaving for some matchers #108

Open
sapkra opened this issue Jan 30, 2020 · 0 comments
Open

Add option to disable interleaving for some matchers #108

sapkra opened this issue Jan 30, 2020 · 0 comments

Comments

@sapkra
Copy link

sapkra commented Jan 30, 2020

I found out a problem with a scenario when two matchers are conflicting. One example is when I'm matching for underscores and the UrlMatcher is matching for URLs which can include underscores.

https://github.com/milesj/interweave/blob/master/packages/emoji-picker/tests/__snapshots__/Emoji.test.tsx.snap

Two links are generated and in between one part is italic.
image
and when I change the order just one link is generated but it's still italic:
image

It would be helpful if there would be an option to disable interleaving for specific matchers. For classes it would be great to have them in the constructor options and for the objects inside the MatcherInterface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant