Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangePassword.tsx react-bootstrap -> react-hook form migration #295

Open
mikhael28 opened this issue Aug 20, 2022 · 4 comments
Open

ChangePassword.tsx react-bootstrap -> react-hook form migration #295

mikhael28 opened this issue Aug 20, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers and newer coders React Involves the React framework

Comments

@mikhael28
Copy link
Owner

Description

There are several areas of the repo that are still using the Bootstrap form components FormGroup, FormControl, ControlLabel, and HelpBlock. These should be migrated to Material UI (FormControl, FormControlLabel, and FormHelperText). In addition, we want to have those components refactored to Hook's from classes (if they aren't already), and to use the react-hook-form npm library to improve the performance of our forms. Review this old Issue for more details. You can refer to Login.js to see what successful implementation looks like.

If you'd like to help, please respond to this issue!

A comprehensive refresher on Material UI forms: https://smartdevpreneur.com/every-material-ui-form-component-explained-mui-v5/

Official docs:
FormControl
FormControlLabel
FormHelperText

@mikhael28 mikhael28 added good first issue Good for newcomers and newer coders React Involves the React framework labels Aug 20, 2022
@AleksandrKurilov
Copy link
Contributor

Hi @mikhael28, could you assign me to the this issue?

@jeremydthomas
Copy link
Collaborator

There you go @AleksandrKurilov let me know if you get stuck.

@AleksandrKurilov
Copy link
Contributor

@jeremydthomas thank you

@mikhael28
Copy link
Owner Author

Thank you @AleksandrKurilov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers and newer coders React Involves the React framework
Projects
None yet
Development

No branches or pull requests

3 participants