Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigpy incompatible with scipy 1.14.0 and numpy 2.0 #142

Open
schuenke opened this issue Jun 25, 2024 · 3 comments · May be fixed by #143
Open

Sigpy incompatible with scipy 1.14.0 and numpy 2.0 #142

schuenke opened this issue Jun 25, 2024 · 3 comments · May be fixed by #143
Labels
bug Something isn't working

Comments

@schuenke
Copy link

schuenke commented Jun 25, 2024

Recently, scipy 1.14.0 and numpy 2.0 have been released and several function signatures have changed leading to problems with the current sigpy version.

The most relevant changes are:

  • np.infty was removed (use np.inf instead)
  • scipy: "Coinciding with changes to function signatures (e.g. removal of a deprecated
    keyword), we had deprecated positional use of keyword arguments for the
    affected functions, which will now raise an error."
  • scipy.integrate.{simps,trapz,cumtrapz} have been removed in favour of simpson, trapezoid, and cumulative_trapezoid.
  • the blackman window function needs to be called from scipy.signal.windows instead of scipy.signal directly

I will create a PR, but wanted to open an Issue to ensure users find it here.

@schuenke schuenke added the bug Something isn't working label Jun 25, 2024
@schuenke schuenke linked a pull request Jun 25, 2024 that will close this issue
@schuenke
Copy link
Author

Nobody feels responsible? I already created a PR (#143) for it 2 weeks ago. Shouldn't be to much work left imo.

@jweine
Copy link

jweine commented Jul 23, 2024

Commenting to upvote and create attention. Just to mention, the scipy.firls positional weight argument starts being incompatible from 1.12. (as mentioned in #144)

@schuenke
Copy link
Author

This is still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants