Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons are incorrectly rendered with IconicsTextView + XML #592

Open
smelfungus opened this issue Jul 17, 2021 · 13 comments
Open

Some icons are incorrectly rendered with IconicsTextView + XML #592

smelfungus opened this issue Jul 17, 2021 · 13 comments
Assignees

Comments

@smelfungus
Copy link

About this issue

Some icons are incorrectly rendered with IconicsTextView + XML.

  • Pixel C emulator:
    image

  • Samsung Galaxy S20 Ultra:
    image

Sample code:

<com.mikepenz.iconics.view.IconicsTextView
  android:layout_width="match_parent"
  android:layout_height="wrap_content"
  android:text="@string/title_statistics_chart_success"
  android:textAppearance="?attr/textAppearanceBody2" />
<string name="title_statistics_chart_success">{gmd-trending-up} Success</string>

Details

  • Used support library version:
    androidx.appcompat:appcompat:1.4.0-alpha03
  • Used gradle build tools version 4.2.2 / 7.1.1
  • Used tooling / Android Studio version: 4.2.2
  • Used library version: 5.2.8, 5.3.0-b01

Fonts:

  • com.mikepenz:google-material-typeface:4.0.0.1-kotlin@aar
  • com.mikepenz:community-material-typeface:5.8.55.0-kotlin@aar
@mikepenz
Copy link
Owner

Are they correctly rendered if using as IconicsDrawable?

@smelfungus
Copy link
Author

@mikepenz I just checked this, yes:
image

@mikepenz
Copy link
Owner

Could it be that the font was not initialised, or maybe android API level related?

@smelfungus
Copy link
Author

@mikepenz, let me create a reproducible sample and share it asap.

@smelfungus
Copy link
Author

@mikepenz It seems like the appcompat dependency is causing this issue, it is working with:
androidx.appcompat:appcompat:1.3.1
But starts breaking with:
androidx.appcompat:appcompat:1.4.0-alpha01+
Sample:
https://github.com/dummyco/android-iconics-gh-592

@mikepenz
Copy link
Owner

That's super interesting :/ will have to take a closer look, not sure why that would be.

@mikepenz
Copy link
Owner

Maybe it's time to deprecate all text based forms, and only retain the IconicsDrawable

@mikepenz mikepenz self-assigned this Jul 24, 2021
@mikepenz
Copy link
Owner

Screenshot 2021-07-30 at 09 11 13

I have the feeling something in here overwrites our spannable

@mikepenz
Copy link
Owner

You will have to add app:emojiCompatEnabled="false" to the xml (using their setter to disable it programmatically from the view seems to not work.

@mikepenz
Copy link
Owner

Tried to find a way around, but have not found any solution beside disabling support for it via xml

@smelfungus
Copy link
Author

That's wonderful! Thank you for taking a look 👍🏻

@nonproto
Copy link
Contributor

Just to note this also occurs on compose previews

@Jibonahmed115
Copy link

Are they correctly rendered if using as IconicsDrawable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants