-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snoretoast with custom appid: result ist not passed to callback (electron) #332
Comments
@NaridaL I am also facing the same issue |
I no longer have easy access to Windows. Any help with debugging, implementation, and QA would be greatly appreciated. |
I am facing the same issue, too. I found if you assigned an 'appId' property on options, like this notifier.notify(
{
...
appID: 'com.some.id'
....
}, When you clicking on notification popup, you won't received any response from Line 559 in 2d3927b
But i don't know why. Hope it helps. |
Facing the same issue. |
Noticed this from https://github.com/KDE/snoretoast :
We may need to use this method to set the appid versus just the setappmodelid method |
This actually completely break the interactive notification functionality of this library, which is the only reason to use it over native electron notifications.. Either we show notifications with SnoreToast image+text or we can't respond to any button click |
Use the shell.writeShortcutLink to create or update your application shortcut with the required properties, which are the correct appID and the toastActivatorCLsid. |
@NunoCuradoFuze |
Yes this is my question too!
On Thu, May 6, 2021 at 8:13 AM Araxeus ***@***.***> wrote:
@NunoCuradoFuze <https://github.com/NunoCuradoFuze>
how do you find and set toastActivatorClsid?
could you give some more details please?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABU6Y2PA4B2EPEDQ6HCZTVLTMKWZPANCNFSM4NIRYARQ>
.
--
*Ana Tomboulian*
*CTO | **peerlogic*
480 | 561.1554
***@***.*** | https://www.linkedin.com/in/anatomboulian/
|
Look for Shell API electron. Example on how to use the writeShortcutLink to update your current shortcut:
|
@NunoCuradoFuze could you maybe share how you did it? I can't find any documentation about using it with electron :(
|
For @tomboolean and anyone else facing the same issue: check out #347 (comment) @DuBistKomisch has completely fixed the problem in his branch ! 😁 |
@Araxeus amazing! I will have to go thank him! |
I believe SnoreToast internally register the callback with the toast activator clsid If I understand correctly, #347 points to a scenario where you used SnoreToast to install the shortcut. When using the notifier without appID, it would prompt the notification with the SnoreToast text and image. With appID the action buttons wouldn't work if I am correct. |
any update guys? |
sadly still waiting for KDE/snoretoast#15 to get merged and published.. |
There's actually a pretty easy way to fix this, we just didn't implement SnoreToast well enough: Here's a guide: #424 |
I don't know if this is specific to electron...
In any case, here's a minimal repro:
https://github.com/NaridaL/electron-node-notifier-bug
The text was updated successfully, but these errors were encountered: