Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus current chapter --> Locate Current Chapter OR Locate Current Chapter In Side-List #329

Closed
zeoint opened this issue Jan 19, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@zeoint
Copy link

zeoint commented Jan 19, 2024

Type of reader (if reader related)

image

Description of the new feature / enhancement

Both image and epub reader related.

Currently the focus chapter icon does not reflect whether it is on or off.
It should reflect its status.


b1

Scenario when this would be used?

To know at a glance if its enabled or disabled.

Supporting information

Example,

  • When the list is enabled, the button changes to hide list. If the list is disabled it changes to show list.
  • When the side list is pinned, the icon tilts indicating the list is pinned.
@zeoint zeoint added the enhancement New feature or request label Jan 19, 2024
@github-project-automation github-project-automation bot moved this to For Review in yomikiru todo Jan 19, 2024
Copy link

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

@mienaiyami
Copy link
Owner

Maybe you misunderstood it.

The button in side-list is not a toggle, when clicked, it only scrolls current chapter to view (in side-list). It only has one function, and is not a "state".

You might be confusing it with the "EPUB: Focus current chapter in side-list" which is different thing. It will toggle "auto focus current chapter when you change chapters. Finding and scrolling to the current chapter can be heavy if there are over 500 entries in side-list.

The button in reader can be used with "auto focus" disabled to prevent huge lag when moving through chapters, and still have the ability to show current chapter in a huge list.

@zeoint
Copy link
Author

zeoint commented Jan 19, 2024

So, basically the Icon's purpose is to "Locate The Current Chapter" in side list. For example, I read about some 'a' chapters in zen mode, after that I opened side list, now that button is used to locate the current chapter in side list only.

Maybe that tooltip should be changed to avoid confusion,

  • Focus Current Chapter -->Locate Current Chapter, since its a location icon and it would also better reflect its function.
  • I was getting confused because of the word 'focus'. After your above explaination I understood its function.
  • But I still think it would be better to change the word to avoid confusion in the future.

@zeoint zeoint changed the title Focus current chapter icon Focus current chapter --> Locate Current Chapter OR Locate Current Chapter In Side-List Jan 19, 2024
@mienaiyami mienaiyami moved this from For Review to Todo in yomikiru todo Jan 19, 2024
@mienaiyami mienaiyami moved this from Todo to Done in yomikiru todo Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants