Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding Type layout for epub, xhtml and txt #328

Open
zeoint opened this issue Jan 18, 2024 · 7 comments
Open

Padding Type layout for epub, xhtml and txt #328

zeoint opened this issue Jan 18, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@zeoint
Copy link

zeoint commented Jan 18, 2024

Type of reader (if reader related)

epub

Description of the new feature / enhancement

Reference For The Requested Feature - Padding Type Layout


1. For this type of layout there should be six new buttons / values in epub reader settings,

  • Border Line Thickness (Value or Slider)
  • Border Line Color
  • Border Inside & Outside BG Color
  • Border Padding Left & Right (Border line should only be on the left and right side. Top and bottom border is unnecessary).

2. The border line should respect the border padding left and right value while Increasing / Decreasing Font Size and width.

Zooming.Behavior.mp4

3. Sample / Reference Image Of Reader Settings,

Layout


R1

Scenario when this would be used?

For reading epubs, xhtml with lesser eye strain. That layout also looks good.

Supporting information

I copied hex value of the colors used on the website and applied the same in yomikiru, but without the border and border outside bg color, it does not feel right.

@zeoint zeoint added the enhancement New feature or request label Jan 18, 2024
Copy link

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

@zeoint
Copy link
Author

zeoint commented Jan 18, 2024

Only when the padding style is enabled the below 6 buttons should be editable, otherwise uneditable.
Like color filters in image reader settings. Only when 'use color filters' button is enabled its below related options are editable.

@mienaiyami
Copy link
Owner

Will be adding it as low priority, so might take a long time before its implemented.

But you can use this css as temporary solution.

body #app #EPubReader section.main>.cont{ 
    border: 1px solid;
    border-color: red;
    padding-left:40px;
    padding-right:40px;
    background-color: grey;
}

add this to your existing custom .css file or create a new custom.css file with this text inside, and then set it using settings.
Feel free to ask for help in setup.

@mienaiyami
Copy link
Owner

mienaiyami commented Jan 18, 2024

If you want to use background color from the reader setting, then do this.

#EPubReader > section{
   background:var(--body-bg-color);
}
body #app #EPubReader section.main>.cont{ 
    border: 1px solid;
    border-color: red;
    padding-left:40px;
    padding-right:40px;
}

and if you want border color to be same as font color replace with this

border-color: var(--epub-font-color);

@zeoint
Copy link
Author

zeoint commented Jan 19, 2024

Cool, thanks.
When you implement this, please remove the top and bottom margins as they are unnecessary.
The left and right borders should touch the topbar and bottom of the page.


b1
b2

@zeoint
Copy link
Author

zeoint commented Jan 19, 2024

A couple reminders for the purpose of clarity,

  • Enabling padding style should freeze the above background, font color buttons and un-freeze the padding style's 7 related buttons.
  • Disabling padding style should freeze its 7 related buttons and un-freeze the above bg, font color.
  • This is for ease of access when switching between those two layouts.

29

@zeoint zeoint changed the title Padding Type layout for epub, xhtml Padding Type layout for epub, xhtml and txt Jan 19, 2024
@omodia
Copy link

omodia commented Jan 21, 2024

Nice Layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants