Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Real-ESRGAN for Image Quality Improvement #289

Closed
MattyMroz opened this issue Sep 24, 2023 · 3 comments
Closed

Implementing Real-ESRGAN for Image Quality Improvement #289

MattyMroz opened this issue Sep 24, 2023 · 3 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@MattyMroz
Copy link

MattyMroz commented Sep 24, 2023

Type of reader (if reader related)

image

Description of the new feature / enhancement

The program can further impress users by adding a feature that uses Real-ESRGAN to improve image quality. This feature would create a new folder with rescaled images. Although the process may be a bit slower, the results are impressive. Real-ESRGAN is a powerful tool for improving image quality. There is also Real-CUGAN available here, which can provide similar features.

Links:
Real-ESRGAN:
https://github.com/xinntao/Real-ESRGAN
https://github.com/xinntao/Real-ESRGAN-ncnn-vulkan

Real-CUGAN:
https://github.com/nihui/realcugan-ncnn-vulkan

Real-ESRGAN-GUI:
https://github.com/tsukumijima/Real-ESRGAN-GUI

Scenario when this would be used?

No response

Supporting information

No response

@MattyMroz MattyMroz added the enhancement New feature or request label Sep 24, 2023
@github-actions
Copy link

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

@omodia
Copy link

omodia commented Sep 24, 2023

  1. Fellow user, no offence, but this feature request is impractical.

  2. I honestly think it would be very hectic and time consuming to integrate an upscaler like RealESRGAN into Yomikiru as it is maintained by a single developer, And asking the dev to work on a project of such large scale with the little time he / she might have on hand to maintain the already complicated Yomikiru is impractical.

  3. Why start from scratch when there are already many upto date and actively developed GUI's of RealESRGAN.

  4. For example, Upscayl or waifu-2x uses RealESRGAN and other image upscalers you could choose from.

  5. It would be better to use one of the actively developed GUI rather than starting from scratch. You could upscale the manhwa you want with it and place it in a folder of your choice and then read it in Yomikiru. This is the best solution.

@mienaiyami
Copy link
Owner

Unfortunately what @omodia said is true.
These days I'm not even getting time to fix the existing issue let alone implement something this big. Plus, it will require python packages, I don't have much experience in that either and app's size will be too big with those included.

However, there's #245 which is similar to this and will improve quality. And in my opinion, it will be better to use existing GUI instead because in the end I will need to save those upscaled images on drive to display them either way.

@mienaiyami mienaiyami closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2023
@mienaiyami mienaiyami added the wontfix This will not be worked on label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants