Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display images as they're read from cbz/cbr for Vertical Scroll #270

Closed
uwuceo opened this issue Sep 20, 2023 · 9 comments
Closed

Display images as they're read from cbz/cbr for Vertical Scroll #270

uwuceo opened this issue Sep 20, 2023 · 9 comments
Labels
enhancement New feature or request reader:image Issues related to manga/comic reader of the app

Comments

@uwuceo
Copy link

uwuceo commented Sep 20, 2023

Description of the new feature / enhancement

You would be able to scroll through images as they're read from disk, without waiting for all of them to load.

This would make for a more pleasant experience, as the first images are displayed faster, and the rest can load while you're on the first couple of images.

An example of this would be YACReader for iOS, which opens chapters without delay, and loads the rest while you're reading, clearing them from memory after it's a distance off-screen.

Scenario when this would be used?

While using Vertical Scroll.

Supporting information

YACReader webtoon example:

https://files.catbox.moe/t5clg9.MP4

@uwuceo uwuceo added the enhancement New feature or request label Sep 20, 2023
@github-actions
Copy link

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

@mienaiyami
Copy link
Owner

Its already done experimentally.

clearing them from memory after it's a distance off-screen.

Its not really possible because of the app's framework,

@uwuceo
Copy link
Author

uwuceo commented Sep 20, 2023

Can't wait for it to be released then :)

Its not really possible because of the app's framework,

Phones can probably use the extra RAM saved, I don't think it's that important for PC. Faster loading time is all I'm hoping for.

@zeoint
Copy link

zeoint commented Sep 21, 2023

@mienaiyami
I want to ask this before its too late, will the dynamic image loading / lazy loading of images be as an option?
Its not a problem for archive formats if its an option or not, but for folder based images it is.

@mienaiyami
Copy link
Owner

I want to ask this before its too late, will the dynamic image loading / lazy loading of images be as an option?

It is the main feature i added.

Though I still haven't checked everything yet, it's not possible to just read a single image from archives using the tools I use.

@mienaiyami mienaiyami added the reader:image Issues related to manga/comic reader of the app label Sep 21, 2023
@zeoint
Copy link

zeoint commented Sep 21, 2023

I did not understand. So I rephrased the question.

Will this dynamic loading only apply to archives?
Or will it also apply to folder (as chapters) too? (My main concern)
If it is applied to folder (as chapters) without an option the stutter/scrolling might happen.

@mienaiyami
Copy link
Owner

Will this dynamic loading only apply to archives?

Archives cant be loaded dynamically. They must be extracted first, as of now,

It can be enabled from settings and is not enforced.

@zeoint
Copy link

zeoint commented Sep 21, 2023

It can be enabled from settings and is not enforced.

Cool. Thanks.

@mienaiyami
Copy link
Owner

As I said above, I can't load single files from archives using the current tools, so this request is not possible unfortunately.
However, I have added dynamic loading for folder type, to show chapter instantly.

@github-project-automation github-project-automation bot moved this from In Progress to Done in yomikiru todo Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reader:image Issues related to manga/comic reader of the app
Projects
Status: Done
Development

No branches or pull requests

3 participants