This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 328
Gasii_ #3
Open
gasii
wants to merge
725
commits into
miekg:master
Choose a base branch
from
skynetservices:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gasii_ #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What are you trying to do here? |
This reverts commit 1992f5f. Wrong branch...
Allow SkyDNS to forward queries to other authorities, thereby create a mesh of SkyDNS server all working together. Works in theory, lots of hardcoded stuff, but looks quite workable.
Multiple idential RR records should be dedupped so that only one is left. I.e. multiport.th1.kubernetes.local. 3600 IN A 1.1.1.1 multiport.th1.kubernetes.local. 3600 IN A 1.1.1.1 Should return: multiport.th1.kubernetes.local. 3600 IN A 1.1.1.1 Note: I believe the clients don't really care about this and stuff just works, but a good server should not be sending out invalid messages. Also added test case that checks for this. We also dedup the additional section, but for now there is no test for this. Fixes #149
Add an Etcd watch and create the function that parses the result and put them in the stubzone's map so that skydns knows what to do.
fix typo: ectd -> etcd
When forwarding queries to another stub add a custom EDNS0 option that tell SkyDNS that this is a stub forward. Such queries will be handled as normal, except that they won't be forward *again* to another stub. This should prevent all kind of nasty cycles.
The lookup happens with a lowercased path. Add two more tests to make sure we work like this and add a line of documentation.
Disable recursion no matter what other config there is.
Does not work (yet). It groups to aggresively and should drop some services that are not dropped.
Added build parameter
Fix typo
* Fix travis build Just curl a compiled etcd instead of compiling by ourselves. * drop -race
Fixes #276. It's better to panic and pass the control to the process manager (systemd, docker, ...) than to continue with an unexpected configuration.
This reverts commit e18ede9. Breaks more than it fixes.
Old DNS lib would paper over a zero hashlength, newer versions require that the hashlength is set. Use crypto/sha1.Size as the value for this as specified in RFC 5155.
* add support for etcd authentication * add support for etcd basic auth * update README environement variable
* initial set of commit for etcd version 3 support. TTL value is still in default for etcdv3 mode * refactored implementation, tested functionality. * cleanup and refactored
currently, EvictRandom will clean up all cached entries when cache is full. fix it, only clean additional ones
Use prometheus client 1.1.0
This was removed from miekg/dns in commit - miekg/dns@1ff265a#diff-8353741544373e78bb7c8c3f6a0ea2cc. The commit message recommendatation is to check for the unpack error which the current code is doing. Conn.ReadMsg returns err is unpack fails.
Remove checking for ErrTruncated, which is now removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.