Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.WinGetSourceCreator.Helpres not using time server for signing #4948

Open
JohnnyElvis opened this issue Nov 7, 2024 · 1 comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@JohnnyElvis
Copy link

Brief description of your issue

Microsoft.WinGetSourceCreator.Helpres SignFile is not using a time server for signing.

Once a code signing certificate expires signed packages will no longer be usable without a time stamp.

Steps to reproduce

Look into src\WinGetSourceCreator\Helpres.cs

Line 39

Expected behavior

Time stamp is added to signature

Actual behavior

No time stamp is added to signature

Image

Environment

Windows 11 Enterprise

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Nov 7, 2024
@denelon denelon added Issue-Feature This is a feature request for the Windows Package Manager client. and removed Needs-Triage Issue need to be triaged labels Nov 11, 2024
@denelon
Copy link
Contributor

denelon commented Nov 14, 2024

The PreIndexed package source is updated every time the publishing pipeline runs over at winget-pkgs. In general, the index gets refreshed mutiple times per day. I'm not sure we actually need or want to have this package to be usable if it's expired. The winget source reset --force command will reset the sources and the winget source update command would also help a user get the latest version of this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

2 participants