Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index V2 does not properly handle versions of <part>.0 or <part>.###0 #4928

Open
Trenly opened this issue Oct 30, 2024 · 0 comments
Open

Index V2 does not properly handle versions of <part>.0 or <part>.###0 #4928

Trenly opened this issue Oct 30, 2024 · 0 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@Trenly
Copy link
Contributor

Trenly commented Oct 30, 2024

When moving from IndexV1 to IndexV2 the code which builds up the index was heavily modified to optimize the size of the index. This has resulted in a parsing error, where versions such as 128.0 or 132.0 do not have the trailing .0 mapped into their version. When the version is more than two parts, or does not end in 0, the version is parsed properly. This only affects IndexV2.

This seems to affect latest_version, arp_min_version, and arp_max_version

For example -

  • 128.0 -> 128
  • 11.10 -> 11.1

Image
Image

My best guess is that the version information isn't being handled explicitly as a string. When there is only a single decimal point, it then gets parsed as a number

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Oct 30, 2024
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Oct 30, 2024
@denelon denelon added this to WinGet Oct 30, 2024
@denelon denelon moved this to To Do in WinGet Oct 30, 2024
@denelon denelon pinned this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
Status: To Do
Development

No branches or pull requests

2 participants