Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize let/const exports in vscode.d.ts #216555

Open
roblourens opened this issue Jun 18, 2024 · 0 comments · May be fixed by #219596
Open

Normalize let/const exports in vscode.d.ts #216555

roblourens opened this issue Jun 18, 2024 · 0 comments · May be fixed by #219596
Assignees
@roblourens
Labels
api api-finalization debt Code quality issues
Milestone
July 2024

Comments

@roblourens
Copy link
Member

Some properties in extension API like

vscode/src/vscode-dts/vscode.d.ts

Line 10349 in 0dfcf2c

export let activeTextEditor: TextEditor | undefined;
are exported with let because they can change, but this also implies that extensions can set them. That isn't allowed, only vscode can change them. Some similar properties already use const. We should normalize these to const everywhere to avoid confusion.

readonly communicates the intent a little better, but this is a namespace, not properties on an interface. But I think it's clear from the name and behavior that these properties will change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
api api-finalization debt Code quality issues
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

Use 'const' in vscode.d.ts to show that props are not assignable microsoft/vscode
1 participant
@roblourens