Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Drag and Drop files onto extensions also opens the file inside the default application for that file type #218626

Open
swordensen opened this issue Jun 26, 2024 · 3 comments · May be fixed by #219148
Open

[Bug] Drag and Drop files onto extensions also opens the file inside the default application for that file type #218626

swordensen opened this issue Jun 26, 2024 · 3 comments · May be fixed by #219148
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release webview Webview issues
Milestone
June 2024 Recovery 1

Comments

@swordensen
Copy link
Contributor

Type: Bug

  1. clone repo https://github.com/maxbublik/vscode-customeditor-drop
  2. press f5 to demo repo
  3. drag and drop any file into the extension editor while holding shift

Notes:
I am primarily creating this issue to track the bug I made with #209211

VS Code version: Code - OSS Dev 1.91.0 (Commit unknown, Date unknown)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info
Item Value
CPUs AMD Ryzen 7 5800X 8-Core Processor (16 x 3800)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.93GB (20.85GB free)
Process Argv . --disable-extension=vscode.vscode-api-tests
Screen Reader no
VM 50%
Extensions disabled
Recording.2024-06-26.144912.mp4
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.90.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@swordensen swordensen mentioned this issue Jun 26, 2024
Closed
@alexr00 alexr00 assigned mjbvz and unassigned alexr00 Jun 27, 2024
@swordensen
Copy link
Contributor Author

My plan is to bubble up the "drop" event like I did with the "drag" event and prevent default in the webviewDragAndDrop setting.

However, I think it should be noted that extension developers can prevent default on their own and prevent the files from opening.

I'm not 100% sure if VSCode should assume that responsibility or not but I'll make the PR anyways once I verify that my idea works. Probably this weekend when I have time!

@swordensen swordensen linked a pull request Jun 28, 2024 that will close this issue
Open
@swordensen
Copy link
Contributor Author

I didn't need to bubble up the event since VSCode doesn't need to do anything with the drop event. I simply prevented default within the extension iframe html.

@mjbvz mjbvz modified the milestones: July 2024, June 2024 Jul 2, 2024
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues labels Jul 2, 2024
@mjbvz mjbvz mentioned this issue Jul 3, 2024
Open
@mjbvz mjbvz added the candidate Issue identified as probable candidate for fixing in the next release label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release webview Webview issues
Projects
None yet
Milestone
June 2024 Recovery 1
Development

Successfully merging a pull request may close this issue.

Fixes #218626 swordensen/vscode
5 participants
@Yoyokrazy @mjbvz @swordensen @alexr00 @VSCodeTriageBot