Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing dialog: Disable other keymaps ('…') to avoid conflicts between keybindings? #104

Closed
clozach opened this issue Oct 3, 2018 · 2 comments

Comments

@clozach
Copy link

clozach commented Oct 3, 2018

The "Disable other keymaps" dialog has serious usability issues.

First there's ambiguity in what will happen if I click, "Yes"…so I never do. Is it saying that all keymaps other than Atom Keymap will be disabled? Or is it saying that Atom Keymap is the "other", and it's the one that will be disabled? Perhaps more importantly, if I make a mistake, how will I know how to fix it? What part of the settings will this affect? Is there a view that shows keymap conflicts that I can view before making this decision?

As it is, the path of least resistance while I'm busy trying to focus on getting work done has always been to just hit "No" and get on with my day. Which is probably lazy of me, but I suspect my psychology isn't too different from others in this regard.

Possibly-useful changes, from least-effort to most:

  • Rewrite the message to explicitly lay out the consequences of choosing Yes
  • Include details about how to change the setting in the future.
  • Link to VS Code documentation explaining keymaps
  • Correct the documentation, which references an apparently-obsolete "Show Conflicts". (It's apparently been re-labelled to "Show Same Keybindings"). Or does that text change contextually?
  • Augment the docs with instructions for how to discover keybindings that directly conflict (as opposed to just being "same" but unconflicting)
  • Best, but definitely not trivial: change the dialog to something like, Keymap conflict detected. Would you like to see the conflicts highlighted in the Keyboard Shortcuts editor?
@andig
Copy link

andig commented May 2, 2019

Reading #98 this sounds more like a vscode than a plugin issue?

@clozach
Copy link
Author

clozach commented Aug 12, 2019

Goodness, you're right. I must have lazily elided the sublime in vscode-sublime-keybindings. I'll repost over on #98 in case these ideas prove useful over there.

Thanks, @andig…and sorry for not replying sooner. 🥴

@clozach clozach closed this as completed Aug 12, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants