Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing "Esc" on a comment being written deletes the comment content while keeping the line range #6235

Closed
jmg-duarte opened this issue Sep 18, 2024 · 4 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@jmg-duarte
Copy link
Contributor

jmg-duarte commented Sep 18, 2024

  • Extension version: 0.96.0
  • VSCode Version: 1.93.1
  • OS: MacOS Catalina
  • Repository Clone Configuration (single repository/fork of an upstream repository): Single repo
  • Github Product (Github.com/Github Enterprise version x.x.x): Github.com

Steps to Reproduce:

  1. Open a comment for a line range or even a single line
  2. Write something
  3. Close the box with "Esc"
  4. Re-open the same box

Expected outcome:

  • Either for Esc not to close it (can probably be configured with focus settings)
  • For a single line: if I re-open the same line I expect the text I was writing to still be there while I have the diff/file open, if the file is closed, the text can be gone
  • For multiple lines: since it already keeps the line range, just keep the text around for the same text range until de-selected

In other, much simpler words: please don't delete the text I have because I pressed "Esc" — I'm using VSCode Vim and just deleted a big comment twice 😭

If you give me some pointers where I can look to investigate how to solve this, I can take some time to try and help!

Note: it seems that this doesn't always happen, I had a comment that was kept but I'm not sure if I left it with "Esc", but it's definitely not consistent.

@fhdiaze
Copy link

fhdiaze commented Sep 24, 2024

I have the same problem? Have you found a work around?

@jmg-duarte
Copy link
Contributor Author

I have the same problem? Have you found a work around?

Not clicking "Esc" — I wish I was joking

@jamesgecko
Copy link

jamesgecko commented Oct 3, 2024

This is a huge show-stopper for users with vim keybindings. I can't even exit insert mode without deleting the comment.

An application should never delete text without either prompting or an undo option.

Possible duplicate of #1455.

@alexr00
Copy link
Member

alexr00 commented Oct 22, 2024

Duplicate of #1455, will aim to add next month!

@alexr00 alexr00 marked this as a duplicate of #1455 Oct 22, 2024
@alexr00 alexr00 closed this as completed Oct 22, 2024
@alexr00 alexr00 added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants