-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlite3] Provide cmake target SQLite::SQLite3 #31659
Comments
IMO the official target doesn't belong into the unofficial config. However, there are many official find modules which poorly support multi-config or static usage requirements. I just refreshed #27408 which tests some common modules incl. SQLite3. |
Wonderful work in #27408 . Adding wrappers for all official find modules is great. As the maintainer of CMake states that they rarely add find modules anymore https://gitlab.kitware.com/cmake/cmake/-/issues/24607#note_1335831. |
Well, #27408 is only the (modified) test port. It doesn't fix a single package for multi-config. |
vcpkg's sqlite3 package does provide the See https://github.com/SchaichAlonso/vcpkg-sqlite-demo for a minimal project using that target. The github CI can use find_package(SQLite3) to find the vcpkg installed sqlite, imply all compile/link options via the SQLite::SQLite3 target and set it up to be used at run-time, too. |
@SchaichAlonso Please build your demo with |
|
This is not the point. The point is that it is not setup to provide multi-config info. |
This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment. |
This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment. |
CMake 3.14+ provides a official
FindSQLite3
module andSQLite::SQLite3
target.It would be good that vcpkg also provides the same name instead of
unofficial::sqlite3::sqlite3
. TheFindSQLite3
module does not support multi-config generators well.The text was updated successfully, but these errors were encountered: