Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-extractor] Re-exporting of module "namespaces" across package boundaries yields malformed type roll-ups #4807

Open
Josmithr opened this issue Jun 25, 2024 · 1 comment
Assignees

Comments

@Josmithr
Copy link
Contributor

Josmithr commented Jun 25, 2024

Summary

See this repo for a repro of the issue: https://github.com/Josmithr/api-extractor-playground/tree/re-export-module-namespace

The repo contains 2 packages, package-a and package-b.
package-b depends on package-a, and both are configured with API-Extractor.

In this scenario, package-a contains a single root export, which is a "namespace" generated via:

import * as A from './NamespaceModule.js';
export { A };

It's type rollup, generated by API-Extractor looks like this:

declare namespace A {
	export { Foo, bar, Baz };
}
export { A };

/** @public */
declare const bar = 5;

/** @public */
declare interface Baz {
	value: string;
}

/** @public */
declare class Foo {}

export {};

package-b also contains a single root export, which is simply a re-export of namespace A from package-a.
It is also configured with package-a specified in its bundledPackages.
Its export looks like this:

export { A } from 'package-a';

I would expect package-b's type roll-up to look identical to that of package-a, but instead, a malformed rollup is generated:

export declare namespace A {
	{
		Foo, bar, Baz;
	}
}

export {};

Notice that the necessary imports are missing for Foo, bar, and Baz.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/api-extractor version? 7.47.0
Operating system? Linux (GitHub Codespace)
API Extractor scenario? reporting (.api.md) / rollups (.d.ts) / docs (.api.json)
Would you consider contributing a PR? Yes
TypeScript compiler version? 5.5.2
Node.js version (node -v)? 20.12.1
@iclanton
Copy link
Member

@octogonz

@iclanton iclanton assigned iclanton and octogonz and unassigned iclanton Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Investigation
Development

No branches or pull requests

3 participants