[rush] Differentiate remote and local execution in telemetry. #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions that were executed remotely and locally
aramissennyeydd
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
approved these changes
May 31, 2024
Comment on lines
+853
to
+855
| wasExecutedOnThisMachine: | ||
| !operationResult.cobuildRunnerId || | ||
| operationResult.cobuildRunnerId === cobuildConfiguration?.cobuildRunnerId, |
There was a problem hiding this comment.
Strictly speaking, does a replay from cache count as "executed on this machine"?
There was a problem hiding this comment.
Open to other names here. Strictly speaking, kind of/kind of not right? Cobuilds are intended to be state restores across machines as though it was built on any given cobuild agent, but from the data, that build wasn't executed on this machine b/c the cobuild runner ids from the state file and machine's cobuild config don't match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4737. My goal is to address data skew questions before we go ahead with #4680 which just adjusts the data skew.
Details
There is no great way currently to determine if telemetry for an operation was generated from the current machine or a remote machine. This is likely to cause data skew depending on how you ingest the Rush telemetry, either
nonCachedDurationMs, which causes multiple events with the same duration (+/- a few milliseconds) if you emit events from each cobuild agent. That messes with averages and whatnot when aggregating your data.startTimestampMsandendTimestampMswhich causes massive spikes in duration collected across your agents, as all but the primary agents report0.05sand the primary agent reports15.00s. That also messes with averages and whatnot during aggregation.I propose a new
wasExecutedOnThisMachineflag that monorepo maintainers can then use in their plugins to decide whether or not they want to process the given operation's data.How it was tested
Tested in this repository, using the
sharded-reposandbox.Impacted documentation
Anything where Rush describes writing your own telemetry plugin.