Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer different pylance modes to enable light vs full IntelliSense experience #5434

Open
luabud opened this issue Feb 1, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@luabud
Copy link
Member

luabud commented Feb 1, 2024

Right now we can tweak settings such as enabling/disabling indexing, changing indexing limit, packageIndexDepths etc to decrease/increase the amount of resources that are used, which also impacts the type of information we are able to offer as part of our IntelliSense features. It'd be nice if we had different indexing "modes" (e.g. lightweight for stdlib and open files only, default for what we do now, and full which indexes as much as we can) that users can change depending on what they want and need.

@luabud luabud added the enhancement New feature or request label Feb 1, 2024
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Feb 1, 2024
@heejaechang
Copy link
Contributor

this will require some groundwork before doing this work.

  1. resolve indexing perf regression we are having (or improve it better than before)
  2. support requirements.txt and pyproject.toml to limit how much we index, show in completion and etc in full mode (otherwise, it will be too much)
  3. support alias in user files's indexing (we have cut it due to perf issue)

@heejaechang
Copy link
Contributor

1. resolve indexing perf regression we are having (or improve it better than before)

this has been handled by https://github.com/microsoft/pyrx/pull/5007 and microsoft/pyright#7652

@luabud
Copy link
Member Author

luabud commented Jun 25, 2024

One idea inspired by cases like #6055 is to have lightweight mode disable workspace wide features, and offer open file support only

@heejaechang
Copy link
Contributor

there is another issue that UX could be improved by light mode - #5881

@heejaechang heejaechang changed the title Offer different indexing modes to enable light vs full IntelliSense experience Offer different pylance modes to enable light vs full IntelliSense experience Jun 27, 2024
@heejaechang heejaechang assigned heejaechang and unassigned KacieKK Jul 8, 2024
@heejaechang
Copy link
Contributor

another PR related to this issue - https://github.com/microsoft/pyrx/pull/5437

@nineteendo
Copy link

Did you mean: microsoft/pyright#5437?

@heejaechang
Copy link
Contributor

@nineteendo no, that's not related to this work. might be related to something @debonte working on that's about doc annotation?

@nineteendo
Copy link

Is microsoft/pyrx just a private repo?

@rchiodo
Copy link
Contributor

rchiodo commented Jul 24, 2024

Is microsoft/pyrx just a private repo?

Yes it's the source location for Pylance. Which is based on Pyright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants