New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clamp] The cmd command is only applicable to Windows #193

Open

heyingquan0030 opened this issue Mar 26, 2024 · 0 comments

heyingquan0030 commented Mar 26, 2024

This code can only run on Windows because other systems do not support the cmd command.

muzic/clamp/clamp.py

Line 127 in 4dc1c56

    
           p = subprocess.Popen('cmd /u /c python inference/xml2abc.py -m 2 -c 6 -x "'+filename+'"', stdout=subprocess.PIPE)

I have modified the command locally as follows:

p = subprocess.Popen(['python', 'inference/xml2abc.py', '-m', '2', '-c', '6', '-x', filename], stdout=subprocess.PIPE)

It runs correctly on macOS and I believe this command is also applicable to Windows and other operating systems.

Therefore, I suggest removing cmd /u /c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment