Application crash when moving/changing state on a Window after calling Close on WebView2 before it's unloaded

[NicholasChrzan]

Describe the bug

If you call Close on a WebView2 control before the control has been unloaded and change the position of the window (changing Overlapped presenter in our case) the app will crash.

The root cause of this looks like the AppWindow.Changed event is unwired in the Unloaded event and not in the Close method. When the window position changes the NotifyParentWindowPositionChanged is called on the CoreWebViewController which causes an access violation which crashes the application.

I have a crash dump file if needed.

A workaround is to call the Close in the Unloaded event of the WebView2.

Steps to reproduce the bug

1. Maximize window (OverlappedPresenter.Maximize)
2. Call Close on WebView
3. Restore Window (OverlappedPresenter.Restore)

Expected behavior

No response

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.6.3: 1.6.241114003

Windows version

Windows 11 (23H2): Build 22631

Additional context

No response

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Closed similar issues:

• WinUI 3 app window with WebView2 crashes when closing (#8395), similarity score: 0.83

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[karkarl]

This seems to be a dupe of #8395 that should have been resolved here: #8395 (comment)

Can you provide a crash dump or repro app, this may be a regression.

[NicholasChrzan]

@karkarl We found this crash when moving from 1.4->1.6. I do have a crash dump, how can I upload it to you (it's not letting me attach it here)?

[NicholasChrzan]

Also. to clarify this isn't related to Window.Close() it's related to the WebView2.Close() method.

For looking at this in WinDbg:

The crash happens here when calling m_coreWebViewController.NotifyParentWindowPositionChanged();

This AppWindow.Changed event is subscribed in the TryCompleteInitialization

But it's only released in the OnUnloaded event

If "WebView2.Close" is called before the OnUnloaded and the AppWindow changes position then m_coreWebViewController.NotifyParentWindowPositionChanged(); is called but since the WebView2 has been closed this is no longer allowed and will throw an access violation.

We were able to work around this by moving our call to Close into the unloaded event and the crash didn't occur.