Remove hardcode sleeps in dpdksuite.py

[squirrelsc]

There are three hardcode sleep 10 or 15 seconds. Please use a timout loop to detect the behavior. Not use the hard code big sleep number.

[mcgov]

I think we removed these, there's a rewritten timeout function that runs dpdk for 10 seconds, this is required since testpmd will just continue to run until you kill it with SIGINT. Can you check

lisa/microsoft/testsuites/dpdk/dpdktestpmd.py

Line 216 in c36e493

def run_for_n_seconds(self, cmd: str, timeout: int) -> str:

and take a look?

[mcgov]

There's another use of the function at

lisa/microsoft/testsuites/dpdk/dpdksuite.py

Line 788 in c36e493

return (testkit, testkit.testpmd.run_for_n_seconds(cmd, seconds))

in the wrapper we use to run testpmd concurrently on nodes.

[squirrelsc]

It's ok to have them in a command like "timeout 10; ...". But below pattern is not encouraged, which is easy to misuse.

lisa/microsoft/testsuites/dpdk/dpdksuite.py

Line 799 in c36e493

time.sleep(10) # run testpmd for a bit before disabling sriov

[LiliDeng]

now hard code sleep moved into dpdkutil.py after this PR https://github.com/microsoft/lisa/pull/1824/files#diff-1c721f3db2542187986b69a1de1bac854714b180b224241115b72eb689e7e14cR235 @mcgov