Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[profiler] Move thread-local variable from RefCell to SharedObject #1311

Open
iyzhang opened this issue Jun 18, 2024 · 0 comments
Open

[profiler] Move thread-local variable from RefCell to SharedObject #1311

iyzhang opened this issue Jun 18, 2024 · 0 comments
Assignees
@anandbonde
Labels
enhancement Enhancement Request on an Existing Feature

Comments

@iyzhang
Copy link
Contributor

iyzhang commented Jun 18, 2024

Context

Our profiler currently still uses the interior mutability pattern with RefCell. We should move to our new SharedObject abstraction.

Proposed Solution

Replace the thread local Rc-RefCell with a SharedObject
@iyzhang iyzhang added the enhancement Enhancement Request on an Existing Feature label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anandbonde anandbonde

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anandbonde @iyzhang