Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delegate parameter warning #6722

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jenshnielsen
Copy link
Collaborator

Closes #6715

@thangleiter Could you check if this is a reasonable solution

  • Add changelog entry

@jenshnielsen jenshnielsen requested a review from a team as a code owner December 16, 2024 12:29
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.38%. Comparing base (151e0e5) to head (cbdc9bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6722   +/-   ##
=======================================
  Coverage   69.38%   69.38%           
=======================================
  Files         340      340           
  Lines       31334    31337    +3     
=======================================
+ Hits        21741    21744    +3     
  Misses       9593     9593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thangleiter
Copy link
Contributor

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_parameter() with DelegateParameter have inconsistent defaults for bind_to_instrument
2 participants