Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Icon Rendering on HL2/VR devices. #8713

Closed
RogPodge opened this issue Sep 29, 2020 · 2 comments · Fixed by #8739
Closed

Improve Icon Rendering on HL2/VR devices. #8713

RogPodge opened this issue Sep 29, 2020 · 2 comments · Fixed by #8739
Assignees
Labels
Feature Request Feature request from the community
Milestone

Comments

@RogPodge
Copy link
Contributor

RogPodge commented Sep 29, 2020

Describe the problem

Related to provencher/MRTK-Quest#64 (comment)

Icon rendering is noticeably blurry on VR devices Hololens 2 (slightly less so for the latter).

button_icon

Describe the solution you'd like

To address this improving the default icon shader with supersampling has been suggested
https://medium.com/@bgolus/sharper-mipmapping-using-shader-based-supersampling-ed7aadb47bec

The plan is to add make modifications to the MRTK Standard Shader to super sample the mip maps and provide much sharper icon rendering. We'll be making this improvement toggleable on the shader level so users can choose to enable or disable this improvement. Note that there are performance concerns for hololens 1, so we need to take the impact on those users into consideration and need to either not enable this by default or have a way to configure settings based on deploying to Hololens 1 vs HL2/VR devices.

Describe alternatives you've considered

We've considered creating a new shader with these improvements, though this approach would create further confusion for users for the "right way" to render icons with MRTK, so we'll be making these improvements to the default shader instead and making it toggleable.

@RogPodge RogPodge added the Feature Request Feature request from the community label Sep 29, 2020
@RogPodge RogPodge self-assigned this Sep 29, 2020
@cre8ivepark
Copy link
Contributor

Added GIF image captured by @vaoliva
@Cameron-Micka for visibility

@vaoliva
Copy link
Contributor

vaoliva commented Oct 7, 2020

I believe this issue was also described on #7941

@keveleigh keveleigh added this to the MRTK 2.6.0 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature request from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants