Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify code to replace RID workaround for .NET 8 migration #81

Open
chenss3 opened this issue Dec 14, 2023 · 0 comments
Open

Modify code to replace RID workaround for .NET 8 migration #81

chenss3 opened this issue Dec 14, 2023 · 0 comments
Labels
Area-Build Pertains to the build system, CI, infrastructure Issue-Task Feature request that doesn't need a major design Type-CodeHealth Related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Milestone
DHAE v0.14

Comments

@chenss3
Copy link

chenss3 commented Dec 14, 2023

Suggested new feature or improvement

With the newest .NET 8 migration, there is a RID workaround needed for reverting back to pre-.NET 8 method of Host using the RID graph to determine assets.

With the recent change in the RuntimeIdentifier graph in addition with RIDs becoming OS version generic, the aforementioned assets that are targeting win10- will not get picked up properly.

Scenario

In the future, we are looking to amend this code so this workaround is not needed.

Additional details

Related to PR #80
@chenss3 chenss3 added Issue-Feature New feature or request Needs-Triage New issue that the core contributors need to triage labels Dec 14, 2023
@chenss3 chenss3 mentioned this issue Dec 14, 2023
Closed
3 tasks
@cinnamon-msft cinnamon-msft added Type-CodeHealth Related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. and removed Needs-Triage New issue that the core contributors need to triage labels Dec 21, 2023
@chenss3 chenss3 mentioned this issue Feb 15, 2024
Merged
3 tasks
@AgneLukoseviciute AgneLukoseviciute mentioned this issue Mar 28, 2024
Open
@krschau krschau added Area-Build Pertains to the build system, CI, infrastructure Issue-Task Feature request that doesn't need a major design and removed Issue-Feature New feature or request labels Apr 1, 2024
@krschau krschau added this to the DHAE v0.13 milestone Aug 12, 2024
@krschau krschau modified the milestones: DHAE v0.13, DHAE v0.14 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Build Pertains to the build system, CI, infrastructure Issue-Task Feature request that doesn't need a major design Type-CodeHealth Related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Projects
None yet
Milestone
DHAE v0.14
Development

No branches or pull requests
3 participants
@krschau @cinnamon-msft @chenss3