-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log delta count in addition to throughput in LoggingMeterRegistry #5548
Comments
The count exported by other registries depends on what is expected with that registry. Some use a cumulative count, some use a delta count, some report each increment, some might use a step-normalized throughput. Since |
In our use case, we want to use:
We considered logging at the level of OpenTelemetry collector for DEV environments but we wanted to avoid extra network costs between applications and collector. We don't plan to use LoggingMeterRegistry to compare metrics with other registries, I agree that it is better to have logging capabilities in each registry (if needed).
I also agree that using |
Sounds reasonable to me. Would you like to make a pull request for it? |
Yes I will. Thanks |
Please describe the feature request.
In LoggingMeterRegistry, instruments such as counter, timer and histogram are logged only with a throughput (e.g.
throughput=0.016667/s
).I propose to add the count next to the throughput in the logs for those instruments (e.g.
throughput=0.016667/s count=1
).Rationale
For instruments such as counter, timer and histogram, throughput is not always the most useful information to log.
In some cases, users want to know the count as it is exported by other meter registries (e.g. OTLP).
Deriving the count from the throughput requires to know the step and it is not always obvious from logs (especially when logInactive is disabled).
Adding the count in the logs next to the throughput would make the logs more clear.
Additional context
N/A
I can provide a PR if it is OK for you.
The text was updated successfully, but these errors were encountered: