Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: new 1.x release with un-deprecated APIs #115

Open
GrahamBorland opened this issue Nov 14, 2024 · 1 comment
Open

Request: new 1.x release with un-deprecated APIs #115

GrahamBorland opened this issue Nov 14, 2024 · 1 comment

Comments

@GrahamBorland
Copy link

GrahamBorland commented Nov 14, 2024

@michaelbull Because of #110 we are locked to v1.x of this library. Would you consider publishing a new 1.x build which removes the @Deprecated warnings on OK and Err? If we're happy using 1.1.21, which we are, it would be nice not to have to suppress that warning everywhere we use those APIs.

We can't downgrade to 1.1.20, pre-deprecation, because we're using some of the newer features in 1.1.21.

@michaelbull
Copy link
Owner

Hi Graham, sorry to hear that the Kotlin team has still not yet prioritised the issue that's stopping your upgrade.

I am open to making a new, unadvertised, 1.1.22 release that simply undeprecates them, but I won't be pushing people to stay on 1.x as I have no plans to maintain it. I'm also unsure how I'm going to do this cleanly as the CI workflow is set up to publish only on changes to master. Maybe if I branch the 1.1.21 release and change the workflow to include the new branch name it'll work - not sure.

As an aside, what happens if you typealias the deprecated methods? I am wondering if they still inherit their underlying type's deprecated nature or does it remove the deprecated warnings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants