feat: add git chart downloader #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoltzsche
force-pushed
the
helm-git-support
branch
13 times, most recently
from
8868a25
to
ff92b7a
Compare
mgoltzsche
changed the title
mgoltzsche
force-pushed
the
helm-git-support
branch
7 times, most recently
from
2450565
to
0d1b29e
Compare
mgoltzsche
force-pushed
the
helm-git-support
branch
3 times, most recently
from
57cfbb8
to
96a4ed3
Compare
This is meant to be compatible with the [helm-git](https://github.com/aslafy-z/helm-git) plugin. The plugin has been reimplemented here since it relies on unsupported helm commands and since it doesn't build git charts as effective as khelm. khelm uses go-git to keep the image small and self-contained: the git binary would increase the container image size by 15m while using go-git increases the size by 3m only. However currently [go-git does not support sparse checkouts](go-git/go-git#90).
Use the credentials configured within repositories.yaml also for git+https urls. To avoid reloading the config, move repository-related code into a separate package.
Also, disable git getter by default and add IsUntrustedRepository method back to helm package for backward-compatibility and convenience.
mgoltzsche
force-pushed
the
helm-git-support
branch
from
96a4ed3
to
9de5d90
Compare
mgoltzsche
force-pushed
the
helm-git-support
branch
from
e0fa730
to
bab9540
Compare
|
I needed this for a previous approach but I don't need it anymore. I am not sure whether it should still be merged since it adds more features to the binary that may be rarely needed but that increase the binary size. Please vote with thumbs up/down whether or not you want this PR to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be compatible with the helm-git plugin.
TL;DR:
The plugin has been reimplemented here since it relies on helm commands khelm does not support and since it doesn't build git charts as effective as khelm. khelm uses go-git to keep the image small and self-contained: the git binary would increase the container image size by 15m while using go-git increases the size by 3m only. However currently go-git does not support sparse checkouts.