Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Does khelm support oci helm registries? #46

Closed
milpog opened this issue Nov 24, 2022 · 6 comments · Fixed by #55
Closed

[QUESTION] Does khelm support oci helm registries? #46

milpog opened this issue Nov 24, 2022 · 6 comments · Fixed by #55
Labels
bug Something isn't working

Comments

@milpog
Copy link

milpog commented Nov 24, 2022

Some projects like https://karpenter.sh are only publishing helm charts to oci. Those registries are supported from Helm v3.8.0. I couldn't make khelm working with this type of registry.

  • chart configuration
apiVersion: khelm.mgoltzsche.github.com/v2
kind: ChartRenderer
metadata:
  name: karpenter
  namespace: kube-system
repository: "oci://public.ecr.aws/karpenter"
chart: karpenter
version: 0.19.2
  • command to render helm chart
export KHELM_TRUST_ANY_REPO=true
kustomize build --enable-alpha-plugins . > karpenter yaml
  • error message
Running khelm 2.2.1 (helm 3.10.1)
Using repository "oci://public.ecr.aws/karpenter" (unauthenticated)
Downloading repository index of oci://public.ecr.aws/karpenter
khelm: load chart karpenter: looks like "oci://public.ecr.aws/karpenter" is not a valid chart repository or cannot be reached: object required
@mgoltzsche
Copy link
Owner

mgoltzsche commented Nov 26, 2022

@milpog thanks for reporting the issue! I wasn't aware of the OCI registry support within helm. When Helm supports it, khelm should do so too. I wonder why it isn't working oob since khelm actually uses Helm. A pull request to also make this work within khelm would be appreciated.
Otherwise I may find some time to look into that myself within a few weeks but currently I cannot spare time for this.

@mgoltzsche mgoltzsche added the bug Something isn't working label Nov 26, 2022
mgoltzsche added a commit that referenced this issue Mar 24, 2023
@husira
Copy link

husira commented Jan 30, 2024

@mgoltzsche Is OCI supported meanwhile or is this pending?

@mgoltzsche
Copy link
Owner

Oh, I am afraid this issue was de-prioritized. OCI repos are still not supported by the latest khelm release. Though, I almost finished implementing that feature within #55. I'll finish and merge that PR the next days...

mgoltzsche added a commit that referenced this issue Feb 1, 2024
mgoltzsche added a commit that referenced this issue Feb 1, 2024
Implemented the helm way: `oci://` URL as `chart` value, empty `repository`.
Repositories configured within the `repositories.yaml` file are ignored when referring to an OCI chart.

Fixes #46
mgoltzsche added a commit that referenced this issue Feb 1, 2024
Implemented the helm way: `oci://` URL as `chart` value, empty `repository`.
Repositories configured within the `repositories.yaml` file are ignored when referring to an OCI chart.

Fixes #46
@mgoltzsche
Copy link
Owner

Now this is fixed within khelm v2.3.2. Sorry for the long delay 😅.

@husira
Copy link

husira commented Feb 6, 2024

Thank you very much for the information and for implementing OCI support :)

mgoltzsche added a commit that referenced this issue Apr 11, 2024
Support specifying an OCI registry URI within the `repository` field of the kustomize plugin or kpt function config.

Relates to #46 and #72
mgoltzsche added a commit that referenced this issue Apr 11, 2024
Support specifying an OCI repository URI within the `repository` field of the kustomize plugin or kpt function config.

Relates to #46 and #72
mgoltzsche added a commit that referenced this issue Apr 11, 2024
Support specifying an OCI repository URI within the `repository` field of the kustomize plugin or kpt function config.

Relates to #46 and #72
@mgoltzsche
Copy link
Owner

mgoltzsche commented Apr 11, 2024

@milpog @husira Using this feature myself really, I realized it wasn't working correctly. I fixed it now and released the fixes with v2.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants