Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request minimal github access #39

Closed
mattbishop opened this issue May 7, 2019 · 2 comments
Closed

Request minimal github access #39

mattbishop opened this issue May 7, 2019 · 2 comments
Labels
github Issues about GitHub platform Platform issues that cannot be solved by Vssue

Comments

@mattbishop
Copy link

What problem does the feature solve?

When a user "Logs in to Github" to set a comment, they are presented with a scary access request that wants all of their data, including access to all their organizations. This is unnecessary and excessive.

Proposed solution

Is there a subset of information that can be asked for? My readers are complaining that they don't want to give me so much access just to leave a comment.

Alternative solutions

Here is the list of github scopes: https://developer.github.com/apps/building-oauth-apps/understanding-scopes-for-oauth-apps/#available-scopes

Additional context

image

@meteorlxy
Copy link
Owner

meteorlxy commented May 8, 2019

Hello, thanks for your feedback.

Vssue is always trying to get the minimal access of the platforms.

Of course we have checked the list, but we could only find public_repo that can access issues & comments. Do you have any clue on that?

Here's the related code about the scope:

scope: 'public_repo',

In fact, during the development of Vssue, we found that:

@meteorlxy meteorlxy added github Issues about GitHub platform Platform issues that cannot be solved by Vssue labels May 8, 2019
@meteorlxy
Copy link
Owner

As this issue could not be solved by Vssue itself, let move to #62 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Issues about GitHub platform Platform issues that cannot be solved by Vssue
Projects
None yet
Development

No branches or pull requests

2 participants