Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict DocumentCollection cache size #1130

Open
metas-ts opened this issue Jan 23, 2019 · 0 comments
Open

Restrict DocumentCollection cache size #1130

metas-ts opened this issue Jan 23, 2019 · 0 comments
Labels
branch:master branch:release type:documentation type:enhancement

Comments

@metas-ts
Copy link
Member

metas-ts commented Jan 23, 2019 •
edited
Loading

Is this a bug or feature request?

FR

What is the current behavior?

Unrestricted DocumentCollection cache size can lead to OutOfMemoryErrors

Which are the steps to reproduce?

What is the expected or desired behavior?

Introduce the sysconfig de.metas.ui.web.window.model.DocumentCollection.CacheSize.
Description:

Specifies the max side of the webui's document cache.
Note that on a machine with 1GB of memory (-Xmx1024M), we ran into an OOME and from the heap dump it turned out that this cache had contained 1474 documents and had reached a heap size of 507MB.
The default if not set is 800.
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jan 23, 2019
@metas-ts
1130-api - Restrict DocumentCollection cache size
64b7180 
add sysconfig to configure the max cache size (default=800)
metasfresh/metasfresh-webui-api-legacy#1130
metas-ts added a commit that referenced this issue Jan 23, 2019
@metas-ts
1130-api - Restrict DocumentCollection cache size
8930b66 
restrict DocumentCollection max cache size (default=800)
#1130
metas-ts added a commit that referenced this issue Jan 23, 2019
@metas-ts
1130-api - Restrict DocumentCollection cache size
20dea59 
solve minor typo
#1130
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jan 23, 2019
@metas-ts
1130-api - Restrict DocumentCollection cache size
a4929f4 
add sysconfig to configure the max cache size (default=800)
metasfresh/metasfresh-webui-api-legacy#1130

(cherry picked from commit 64b7180)
metas-ts added a commit that referenced this issue Jan 23, 2019
@metas-ts
1130-api - Restrict DocumentCollection cache size
5df2d8e 
restrict DocumentCollection max cache size (default=800)
#1130

(cherry picked from commit 8930b66)
metas-ts added a commit that referenced this issue Jan 23, 2019
@metas-ts
1130-api - Restrict DocumentCollection cache size
1dd8682 
solve minor typo
#1130

(cherry picked from commit 20dea59)
This was referenced Jan 23, 2019
Merged
Merged
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jan 27, 2019
@metas-ts
Update ReleaseNotes.md
b3973ae 
  * [#4881](#4881) Different improvements around MSV3 server synchronization
  * [#4886](#4886) Account Schema window: don't allow creating new accounting schemas
  * [#4887](#4887) New Window Tab: callout to automatically set AD_Element_ID, Name, InternalName when a table is selected
  * [#4892](#4892) Add inactive product fields for hu tracing and label printing
  * [#4894](#4894) BPartner Product statistics: LastShipmentDate, LastReceiptDate
  * [#1128](metasfresh/metasfresh-webui-api-legacy#1128) Limit number of products shown in material cockpit
  * [#1132](metasfresh/metasfresh-webui-api-legacy#1132) Sales/Purchase order: customer proposal products list
  * [#1130](metasfresh/metasfresh-webui-api-legacy#1130) Restrict DocumentCollection cache size
  * [#4896](#4896) Errors in Tax Codes Report
  * [#4900](#4900) AD_Val_Rule ESR_Import_AD_AttachmentEntry is broken
  * [#4902](#4902) Process BPartnerOrgLink doesn't set AD_OrgInfo.OrgBP_Location_ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:master branch:release type:documentation type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metas-ts