From 43cca40ac80fdca25bbcbd05332c055cf3405143 Mon Sep 17 00:00:00 2001
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Tue, 7 May 2024 23:26:15 +0530
Subject: [PATCH] fix env vars

---
 .github/workflows/package-macos.yml | 5 +++--
 notarize.js                         | 4 ++--
 package.json                        | 1 +
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/package-macos.yml b/.github/workflows/package-macos.yml
index 9c9ba18..6c97bf9 100644
--- a/.github/workflows/package-macos.yml
+++ b/.github/workflows/package-macos.yml
@@ -45,10 +45,11 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           APPLE_ID: ${{ secrets.APPLE_ID_USER }}
-          APPLE_ID_TEAM: ${{ secrets.APPLE_ID_TEAM }}
-          APPLE_ID_PASS: ${{ secrets.APPLE_ID_PASSWORD }}
+          APPLE_TEAM_ID: ${{ secrets.APPLE_ID_TEAM }}
+          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
           CSC_LINK: ./appledev.p12
           CSC_KEY_PASSWORD: ${{ secrets.CODESIGN_MACOS_P12_PASSWORD }}
 
       - name: Cleanup
         run: rm -f ./appledev.p12
+        if: always()
diff --git a/notarize.js b/notarize.js
index d5e4219..52e7fbb 100644
--- a/notarize.js
+++ b/notarize.js
@@ -25,7 +25,7 @@ exports.default = async function notarizeMacos(context) {
     appBundleId: build.appId,
     appPath: `${appOutDir}/${appName}.app`,
     appleId: process.env.APPLE_ID,
-    appleIdPassword: process.env.APPLE_ID_PASS,
-    ascProvider: process.env.APPLE_ID_TEAM,
+    appleIdPassword: process.env.APPLE_APP_SPECIFIC_PASSWORD,
+    teamId: process.env.APPLE_TEAM_ID,
   });
 };
\ No newline at end of file
diff --git a/package.json b/package.json
index ccc33b1..8467f05 100644
--- a/package.json
+++ b/package.json
@@ -53,6 +53,7 @@
           "x64"
         ]
       },
+      "icon": "./assets/icon.icns",
       "type": "distribution",
       "hardenedRuntime": true,
       "entitlements": "./assets/entitlements.mac.plist",