Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph Data Review & Quality Assurance (QA) - Convex Finance on Ethereum [No-Code Task] #5

Open
ken-m-1 opened this issue Jun 20, 2022 · 3 comments

Comments

@ken-m-1
Copy link

ken-m-1 commented Jun 20, 2022

Goal

Messari is using The Graph as a data source and building subgraphs for each protocol to query on-chain data in a standardized manner. You can see the subgraphs in our repo here: https://github.com/messari/subgraphs

Before using the subgraphs, we need to verify their data quality to ensure data is accurate. If there are any errors, these need to be fixed by our developers.

Task

When a Subgraph is ready for review, go to https://subgraphs.xyz/ and select the Subgraph.

Note that Subgraphs exist per-protocol, per-network. For a protocol like Uniswap v3 which is deployed on Ethereum, Matic, Optimism and Arbitrum, there are 4 separate subgraphs which need to be reviewed. Each view represents Uniswap v3 on a specific network.

Compare each metric in the subgraph against other data sources available. Some common resources have been listed below (not exhaustive):

If there are no other data sources available, the data verification will need to be done heuristically. This can be done in multiple ways, for example comparing the metrics to a protocol of similar size and sense-checking their values are similar (TVL, revenue, etc.).

For each metric, evidence/references/resources should be submitted to clarify how the data was verified. Metrics need to be verified at both the Protocol AND Pool-level across multiple dates, and identifying if chart trends are the same/similar is also useful.

A template and example has been provided here:

Submission Requirements

  • Submissions need to follow the above criteria
  • Protocol and Pool-level data needs to be verified
  • It is recommended to follow the QA examples and template

Subgraphs to QA

  • Convex Finance (Ethereum)

Bounty

  • 300 USDC has been allocated per Subgraph QA-ed
    • If there are multiple successful submissions, the total bounty may be split between individuals
  • The best applicants and Subgraph QA submissions may be offered to complete additional Subgraph QA work as a longer-term relationship

Please contact [email protected] if you have any questions.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 300.0 USDC attached to it as part of the messari fund.

@gitcoinbot
Copy link

gitcoinbot commented Jun 26, 2022

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 6 days, 15 hours ago.
Please review their action plans below:

1) serenityfund has started work.

We have started working on this.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 300.0 USDC (300.00 USD @ $1.0/USDC) has been submitted by:

  1. @serenityfund

@ken-m-1 please take a look at the submitted work:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants